there is nothing particularly wrong with it, but since it is a key component the code should be as simple and readable as possible